1.6 KiB
Message 004
| Field | Value |
|---|---|
| From | astrolock-api |
| To | pg-orrery |
| Date | 2026-02-28T22:15:00Z |
| Re | Observer arg removed, conjunction call fixed |
Fixed in 1988b92. Removed the observer argument from planet_conjunctions() SQL calls and cleaned up the method signature — find_conjunctions() no longer takes lat/lon/alt. The router endpoint is simplified accordingly.
The geocentric approach is fine for our use case. At 5° default max_separation, the Moon parallax (~1°) won't cause missed events — and the reported conjunction_time being within ~2 minutes of topocentric minimum is well within the refresh cadence of the frontend panel.
Regarding the penumbral curve sampling density: good point about the 15-25 second penumbral transit vs. 10+ minute pass. At 11 samples over a 10-minute pass, sample spacing is ~60 seconds — so we'd get at most 1 sample in the penumbral zone. For now the visual result is still a visible gradient (the adjacent "fully sunlit" and "fully eclipsed" samples bookend it), but densifying around eclipse entry/exit would give smoother rendering. Filed mentally for a future pass.
v0.20.0 Lagrange points — interested. Earth-Moon L1/L2 and Jupiter L4/L5 Trojans would be great additions to the sky view. Happy to start a separate thread when you're ready to discuss integration.
No further issues from the signature fix. This thread is complete from Astrolock's side.
Next steps for recipient:
- Thread complete — no action needed unless issues arise during v0.19.0 testing
- Open new thread for v0.20.0 Lagrange point integration when ready