The CLI handling code was redesigned for v0.4 and it seems the code
to assign a default title from v0.3.1 has been messed up. This bug
has not been triggered by build_examples.py due to it seems to call
the parse() function differently.
The output_name should be used as default title when present.
This will fix the #360 bug report.
Bug: Not all generated dot output could be changed by tweak entries.
Seen in https://github.com/wireviz/WireViz/issues/325#issuecomment-2116395221
Tweak processing must be the very last dot producing code to enable
tweaking any dot output.
Fix: Move all other dot producing code above Tweak processing.
Symptom reported in #355: Unable to connect an arrow (mate) to
pins higher than 1 without failing: ValueError: X is not in list
Bug: The code processing mates used a mix of repeated connector
look-ups and local connector variables, and one variable was used
before it was assigned the correct value.
Fix: The local connector variables are now both assigned initially
before processing each mate, and used when processing instead of
repeated connector look-ups.
In Windows might OSError(errno=EINVAL) be raised instead of the already
catched exceptions in some cases (depending on the Python version).
Suggested fix posted by JarrettR in
https://github.com/wireviz/WireViz/issues/344#issuecomment-2113476151
Co-authored-by: JarrettR <jrainier@gmail.com>
`rc2` branch is based directly on `master`. By merging into `rc2`, any merge conflicts can be resolved while leaving `master` intact until final merge is approved.
# Conflicts:
# docs/CHANGELOG.md
# src/wireviz/Harness.py
# src/wireviz/__init__.py
# src/wireviz/wireviz.py
- Resolves#263 that describes warnings and weird loop drawing because
loop connected pins are hidden when hide_disconnected_pins=True.
- Activate loop pins as early as possible to enable correct counting of
connected pins when
connector.additional_components.qty_multiplier=populated.
- Check that loop pins actually exist before activating them.
Hard-coding OS error numbers that differ between different platforms
caused the program to crash at platforms using a different error number.
Using the Standard errno system symbols will avoid this problem.
Co-authored-by: kvid <kvid@users.noreply.github.com>
The two header comments were missing trailing newlines.
This behavior is introduced by v0.18 of the graphviz Python package;
where as v0.17 did include the newline automatically.
Closes#258
