The hour byte of a TIMED program is overloaded as a 1-of-3 discriminator: 0..23 means absolute wall-clock time, 25 means sunrise-relative, 26 means sunset-relative. For the relative forms, the minute byte is signed (sbyte) -- positive = after, negative = before, zero = at. Source: frmPopUpEditTime.cs:186-217 (decode) + :241-263 (encode). This was the canary that tripped our earlier sanity test: slots 182/183 in the live fixture have hour=26 minute=246 and hour=25 minute=10 -- nominally invalid as clock times, but they're "10 min before sunset" and "10 min after sunrise" respectively. With this commit those decode cleanly via TimeKind.SUNSET / SUNRISE. omni_pca.programs: * New TimeKind IntEnum: ABSOLUTE / SUNRISE / SUNSET. * New Program.time_kind property (classifies via hour-byte discriminator). * New Program.time_offset_minutes property (signed minutes-offset for sunrise/sunset; 0 for absolute). * New Program.format_time() -> str: "07:15" | "at sunrise" | "30 min before sunset" etc. * Module-level _classify_time helper + sentinel constants _HR_SUNRISE_SENTINEL=25 / _HR_SUNSET_SENTINEL=26. omni_pca top-level: re-exports TimeKind. tests/test_programs.py (+13 cases): * Parametrised TimeKind classification across absolute / sunrise / sunset including boundary cases (sbyte ±128, ±1, 0). * Wire-bytes round-trip preserves TimeKind + offset. tests/test_pca_file.py: tightened the previously-loosened sanity invariant. ABSOLUTE-time TIMED programs must hit valid wall-clock ranges (0-23 / 0-59); relative-time programs must have a valid sbyte offset (-128..127). Both pass cleanly on the 209 TIMED programs in the live fixture (207 absolute, 1 sunrise, 1 sunset). Full suite: 439 passed, 1 skipped (was 426 / 1).
336 lines
11 KiB
Python
336 lines
11 KiB
Python
"""Unit tests for omni_pca.pca_file.
|
|
|
|
The full ``.pca`` parser is exercised via the live fixture in pca-re/extracted
|
|
which is not committed; here we validate the LCG keystream + reader plumbing
|
|
on synthesized inputs and skip the full-body test by default.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import io
|
|
import struct
|
|
|
|
import pytest
|
|
|
|
from omni_pca.pca_file import (
|
|
KEY_EXPORT,
|
|
KEY_PC01,
|
|
PcaReader,
|
|
decrypt_pca_bytes,
|
|
derive_key_from_stamp,
|
|
)
|
|
|
|
|
|
def _encrypt_with_lcg(plain: bytes, key: int) -> bytes:
|
|
"""Reference encryptor (mirrors decrypt_pca_bytes — same op since XOR)."""
|
|
return decrypt_pca_bytes(plain, key)
|
|
|
|
|
|
def test_decrypt_is_xor_involution() -> None:
|
|
plain = b"CFG05 hello world payload"
|
|
ct = _encrypt_with_lcg(plain, 0xDEADBEEF)
|
|
assert decrypt_pca_bytes(ct, 0xDEADBEEF) == plain
|
|
|
|
|
|
def test_keystream_never_emits_0xff() -> None:
|
|
# The Borland LCG's `% 255` quirk means keystream values are in [0..254].
|
|
# Encrypting a buffer of 0xFF bytes should never produce 0x00.
|
|
ct = _encrypt_with_lcg(b"\xff" * 4096, 0x12345678)
|
|
assert all(b != 0x00 for b in ct)
|
|
|
|
|
|
def test_keys_are_distinct() -> None:
|
|
assert KEY_PC01 != KEY_EXPORT
|
|
|
|
|
|
def test_keys_match_decompiled_constants() -> None:
|
|
# Pin to the literal uint values from clsPcaCfg.cs (decompiled C#).
|
|
# Hex form of each is right next to the constant in pca_file.py.
|
|
assert KEY_PC01 == 338847091
|
|
assert KEY_EXPORT == 391549495
|
|
|
|
|
|
def test_derive_key_from_stamp_is_deterministic() -> None:
|
|
a = derive_key_from_stamp("hello")
|
|
b = derive_key_from_stamp("hello")
|
|
assert a == b
|
|
assert a != derive_key_from_stamp("hellp")
|
|
|
|
|
|
def test_pca_reader_basic_types() -> None:
|
|
buf = bytes([0x05]) + struct.pack("<H", 0xBEEF) + struct.pack("<I", 0xDEADBEEF)
|
|
r = PcaReader(buf)
|
|
assert r.u8() == 0x05
|
|
assert r.u16() == 0xBEEF
|
|
assert r.u32() == 0xDEADBEEF
|
|
|
|
|
|
def test_pca_reader_string8_fixed_consumes_full_slot() -> None:
|
|
# declared len=3, max_len=10 → consumes 1 + 10 bytes regardless
|
|
payload = bytes([3]) + b"abc" + b"\x00" * 7
|
|
r = PcaReader(payload + b"TAIL")
|
|
s = r.string8_fixed(10)
|
|
assert s == "abc"
|
|
assert r.remaining() == b"TAIL"
|
|
|
|
|
|
def test_pca_reader_string16_fixed_consumes_full_slot() -> None:
|
|
payload = struct.pack("<H", 2) + b"ok" + b"\x00" * 4 + b"TAIL"
|
|
r = PcaReader(payload)
|
|
s = r.string16_fixed(6)
|
|
assert s == "ok"
|
|
assert r.remaining() == b"TAIL"
|
|
|
|
|
|
def test_pca_reader_short_read_raises() -> None:
|
|
r = PcaReader(b"\x00\x00")
|
|
with pytest.raises(EOFError):
|
|
r.u32()
|
|
|
|
|
|
@pytest.mark.skip(reason="needs the gitignored extracted/Our_House.pca fixture")
|
|
def test_full_pca_parse_against_real_fixture() -> None:
|
|
# Placeholder — wire up if/when a redacted fixture lands in tests/fixtures/.
|
|
pass
|
|
|
|
|
|
# ---- Programs block extraction against the live decrypted fixture ----
|
|
#
|
|
# These tests need the plaintext .pca dump at the path below — gitignored.
|
|
# If absent, they skip cleanly. If present, they assert the decode against
|
|
# the values established in the Phase 1 RE pass (Programs block, slot 22,
|
|
# the TIMED/EVENT/YEARLY type-distribution counts).
|
|
|
|
_FIXTURE = "/home/kdm/home-auto/HAI/pca-re/extracted/Our_House.pca.plain"
|
|
|
|
|
|
def _load_programs_blob_or_skip() -> bytes:
|
|
from pathlib import Path
|
|
|
|
p = Path(_FIXTURE)
|
|
if not p.exists():
|
|
pytest.skip(f"fixture not available: {_FIXTURE}")
|
|
from omni_pca.pca_file import (
|
|
_CAP_OMNI_PRO_II,
|
|
PcaReader,
|
|
_parse_header,
|
|
_walk_to_connection,
|
|
)
|
|
|
|
r = PcaReader(p.read_bytes())
|
|
_parse_header(r)
|
|
return _walk_to_connection(r, _CAP_OMNI_PRO_II)
|
|
|
|
|
|
def test_programs_block_decodes_against_live_fixture() -> None:
|
|
"""All 1500 slots decode without raising; counts match Phase 1 recon."""
|
|
from collections import Counter
|
|
|
|
from omni_pca.programs import ProgramType, decode_program_table, iter_defined
|
|
|
|
blob = _load_programs_blob_or_skip()
|
|
assert len(blob) == 1500 * 14
|
|
|
|
programs = decode_program_table(blob)
|
|
assert len(programs) == 1500
|
|
defined = list(iter_defined(programs))
|
|
assert len(defined) == 330
|
|
|
|
types = Counter(p.prog_type for p in defined)
|
|
assert types[int(ProgramType.TIMED)] == 209
|
|
assert types[int(ProgramType.EVENT)] == 105
|
|
assert types[int(ProgramType.YEARLY)] == 16
|
|
|
|
|
|
def test_programs_block_round_trips_byte_for_byte() -> None:
|
|
"""The strongest correctness signal: decode → encode → compare.
|
|
|
|
If a single byte of the 21,000-byte blob is off, this test catches it.
|
|
"""
|
|
from omni_pca.programs import decode_program_table
|
|
|
|
blob = _load_programs_blob_or_skip()
|
|
programs = decode_program_table(blob)
|
|
rebuilt = b"".join(p.encode_file_record() for p in programs)
|
|
assert rebuilt == blob
|
|
|
|
|
|
def test_programs_sanity_invariants() -> None:
|
|
"""Coarse invariants on the 330 defined programs.
|
|
|
|
The byte-for-byte round-trip test above is the load-bearing
|
|
correctness signal. The asserts here are belt-and-suspenders:
|
|
|
|
* **YEARLY** uses bytes 9/10 as a real calendar date.
|
|
* **TIMED** programs come in two flavors:
|
|
ABSOLUTE (``hour`` 0..23, ``minute`` 0..59) and
|
|
sunrise/sunset-relative (``hour`` == 25 or 26 — see
|
|
:class:`omni_pca.programs.TimeKind`). The decoder classifies via
|
|
``Program.time_kind``; ABSOLUTE-time programs must hit real
|
|
wall-clock ranges.
|
|
* **EVENT** encodes a u16 event ID in bytes 9/10 rather than
|
|
a calendar date (see ``clsProgram.Evt``); no calendar assertion.
|
|
"""
|
|
from omni_pca.programs import (
|
|
ProgramType,
|
|
TimeKind,
|
|
decode_program_table,
|
|
iter_defined,
|
|
)
|
|
|
|
blob = _load_programs_blob_or_skip()
|
|
programs = decode_program_table(blob)
|
|
defined = list(iter_defined(programs))
|
|
|
|
yearly = [p for p in defined if p.prog_type == int(ProgramType.YEARLY)]
|
|
assert yearly, "fixture should have YEARLY programs"
|
|
for p in yearly:
|
|
assert 1 <= p.month <= 12, (
|
|
f"slot {p.slot} YEARLY: month={p.month}"
|
|
)
|
|
assert 1 <= p.day <= 31, (
|
|
f"slot {p.slot} YEARLY: day={p.day}"
|
|
)
|
|
|
|
timed = [p for p in defined if p.prog_type == int(ProgramType.TIMED)]
|
|
assert timed, "fixture should have TIMED programs"
|
|
for p in timed:
|
|
assert p.days != 0, f"slot {p.slot}: TIMED with no days mask"
|
|
if p.time_kind == TimeKind.ABSOLUTE:
|
|
assert 0 <= p.hour <= 23, (
|
|
f"slot {p.slot} TIMED-ABSOLUTE: hour={p.hour}"
|
|
)
|
|
assert 0 <= p.minute <= 59, (
|
|
f"slot {p.slot} TIMED-ABSOLUTE: minute={p.minute}"
|
|
)
|
|
else:
|
|
# Sunrise/sunset offsets fit in a signed byte.
|
|
assert -128 <= p.time_offset_minutes <= 127
|
|
|
|
|
|
def test_remarks_walker_on_empty_table() -> None:
|
|
"""Hand-built minimal tail with zero description entries + zero remarks."""
|
|
import struct
|
|
|
|
from omni_pca.pca_file import PcaReader, _walk_to_remarks
|
|
|
|
blob = (
|
|
struct.pack("<H", 9) # ModemBaud
|
|
+ b"\x01\x00\x00" # 3 init-enable flags
|
|
+ struct.pack("<H", 0) # AccountRemarks_Extended length 0
|
|
+ (struct.pack("<I", 0) * 9) # 9 description blocks, each count=0
|
|
+ struct.pack("<I", 1234) # _RemarksNextID
|
|
+ struct.pack("<I", 0) # count = 0
|
|
)
|
|
r = PcaReader(blob)
|
|
assert _walk_to_remarks(r) == {}
|
|
|
|
|
|
def test_remarks_walker_decodes_real_entries() -> None:
|
|
"""Hand-built tail with two non-empty description entries + three remarks."""
|
|
import struct
|
|
|
|
from omni_pca.pca_file import (
|
|
PcaReader,
|
|
_DESCRIPTION_SLOT_BYTES,
|
|
_walk_to_remarks,
|
|
)
|
|
|
|
# Two zones with descriptions; everything else has zero entries.
|
|
zone_desc = b"\x06" + b"FOYER!" + b"\x00" * (32 - 6) # 33 bytes
|
|
other_desc = b"\x09" + b"GARAGE LT" + b"\x00" * (32 - 9)
|
|
assert len(zone_desc) == _DESCRIPTION_SLOT_BYTES
|
|
assert len(other_desc) == _DESCRIPTION_SLOT_BYTES
|
|
description_blocks = (
|
|
struct.pack("<I", 2) + zone_desc + other_desc # Zones
|
|
+ struct.pack("<I", 0) * 8 # Units .. AudioZones
|
|
)
|
|
|
|
def _remark_entry(rid: int, text: str) -> bytes:
|
|
t = text.encode("utf-8")
|
|
return struct.pack("<I", rid) + struct.pack("<H", len(t)) + t
|
|
|
|
remarks_block = (
|
|
struct.pack("<I", 99) # _RemarksNextID
|
|
+ struct.pack("<I", 3) # count
|
|
+ _remark_entry(1, "TURN ON LIVING ROOM LIGHTS")
|
|
+ _remark_entry(7, "DOG WALK TIME")
|
|
+ _remark_entry(0xDEADBEEF, "UTF-8 ✓ ☃ ♥")
|
|
)
|
|
|
|
tail = (
|
|
struct.pack("<H", 9) + b"\x01\x00\x00"
|
|
+ struct.pack("<H", 0)
|
|
+ description_blocks
|
|
+ remarks_block
|
|
)
|
|
r = PcaReader(tail)
|
|
remarks = _walk_to_remarks(r)
|
|
assert remarks == {
|
|
1: "TURN ON LIVING ROOM LIGHTS",
|
|
7: "DOG WALK TIME",
|
|
0xDEADBEEF: "UTF-8 ✓ ☃ ♥",
|
|
}
|
|
|
|
|
|
def test_remarks_walker_returns_empty_on_truncated_input() -> None:
|
|
"""A short/garbage tail should yield ``{}``, not raise."""
|
|
from omni_pca.pca_file import PcaReader, _walk_to_remarks
|
|
|
|
# Way too short to hold even the prelude.
|
|
assert _walk_to_remarks(PcaReader(b"\x00" * 5)) == {}
|
|
|
|
|
|
def test_remarks_resolved_against_live_fixture_is_empty_dict() -> None:
|
|
"""Our live fixture has zero remarks programmed; the walker must
|
|
still consume the prelude + nine description blocks + the zero
|
|
count without raising."""
|
|
blob = _load_programs_blob_or_skip() # establishes the fixture exists
|
|
# We've already validated the position at end-of-programs above; now
|
|
# re-walk and continue past Connection through the remarks walker.
|
|
from omni_pca.pca_file import (
|
|
_CAP_OMNI_PRO_II,
|
|
PcaReader,
|
|
_parse_header,
|
|
_walk_to_connection,
|
|
_walk_to_remarks,
|
|
)
|
|
from pathlib import Path
|
|
|
|
raw = Path(_FIXTURE).read_bytes()
|
|
r = PcaReader(raw)
|
|
_parse_header(r)
|
|
_walk_to_connection(r, _CAP_OMNI_PRO_II)
|
|
r.string8_fixed(120)
|
|
r.string8_fixed(5)
|
|
r.string8_fixed(32)
|
|
assert _walk_to_remarks(r) == {}
|
|
|
|
|
|
def test_pca_account_dataclass_has_programs_field() -> None:
|
|
"""``PcaAccount`` exposes ``programs`` with the expected type + default.
|
|
|
|
Verifies the API surface without needing a working .pca decrypt
|
|
key — the integration from raw blob through ``decode_program_table``
|
|
is covered by the other three live-fixture tests above.
|
|
"""
|
|
from omni_pca.pca_file import PcaAccount
|
|
|
|
fields = {f.name: f for f in PcaAccount.__dataclass_fields__.values()}
|
|
assert "programs" in fields
|
|
assert "remarks" in fields
|
|
# Defaults: empty tuple for programs, empty dict for remarks.
|
|
inst = PcaAccount(
|
|
version_tag="PCA03", file_version=3,
|
|
model=16, firmware_major=2, firmware_minor=12, firmware_revision=1,
|
|
)
|
|
assert inst.programs == ()
|
|
assert inst.remarks == {}
|
|
|
|
|
|
def test_pca_reader_io_state_introspection() -> None:
|
|
r = PcaReader(b"abcdef")
|
|
assert isinstance(r.buf, io.BytesIO)
|
|
r.bytes_(2)
|
|
assert r.position() == 2
|