HA: websocket commands + side-panel registration
Phase B of the program viewer. Three websocket commands and a stub
side-panel registration wire the HA integration to consume the
program_renderer library.
Websocket commands (all namespaced ``omni_pca/programs/``):
* ``list`` — paginated, filterable summaries. Filters: trigger_types
(TIMED / EVENT / YEARLY / WHEN / AT / EVERY), references_entity
(e.g. ``"unit:7"``), case-insensitive substring search. Each row
carries summary tokens + a flat ``references`` list for filter UI.
* ``get`` — full structured-English detail for a slot. Clausal
chains return as one logical unit even when the user clicked an
interior slot.
* ``fire`` — sends ``Command.EXECUTE_PROGRAM`` over the wire so the
panel runs the program now. Returns ``{slot, fired: true}`` on
success or a structured error.
Token serialisation uses short keys (k/t/ek/ei/s) for compact wire
format — the panel's 1500-slot table on a busy install fits in a few
hundred KB of JSON.
Coordinator-backed resolvers:
* ``_CoordinatorNameResolver`` — pulls names from data.zones / units /
areas / thermostats / buttons (HA-side ZoneProperties etc.)
* ``_CoordinatorStateResolver`` — pulls live state from *_status maps
so every websocket call sees the freshest available overlay without
round-tripping the panel. SECURE / NOT READY / BYPASSED for zones,
OFF / ON / ON 60% for units, Day / Night / Away for areas,
°F for thermostats.
Side-panel registration: ``async_register_side_panel`` registers a
custom panel under ``Omni Programs`` in HA's sidebar with a
``mdi:script-text-outline`` icon. Bundle is served at
``/api/omni_pca/panel.js`` via a static-path registration. A
working stub panel.js ships now so the wiring is exercisable;
Phase C will drop the real Lit/TS bundle into the same path.
Panel registration is wrapped in a try/except + a once-per-HA-boot
guard so test environments without ``hass_frontend`` installed don't
break the rest of the integration. The manifest only lists ``http``
and ``websocket_api`` as hard dependencies for the same reason —
panel_custom is opportunistic.
10 new HA-integration tests cover list/get/fire end-to-end plus
filters, pagination, search, live-state overlay, and structured-error
returns for bad entry_id / missing slot.
Full suite: 634 passed, 1 skipped (up from 624).
This commit is contained in:
parent
0026c5b00a
commit
ce87ebcb13
@ -26,6 +26,12 @@ from .const import (
|
|||||||
)
|
)
|
||||||
from .coordinator import OmniDataUpdateCoordinator
|
from .coordinator import OmniDataUpdateCoordinator
|
||||||
from .services import async_setup_services, async_unload_services
|
from .services import async_setup_services, async_unload_services
|
||||||
|
from .websocket import (
|
||||||
|
async_register_side_panel,
|
||||||
|
async_register_websocket_commands,
|
||||||
|
)
|
||||||
|
|
||||||
|
_PANEL_REGISTERED_KEY = "_panel_registered"
|
||||||
|
|
||||||
if TYPE_CHECKING:
|
if TYPE_CHECKING:
|
||||||
from homeassistant.config_entries import ConfigEntry
|
from homeassistant.config_entries import ConfigEntry
|
||||||
@ -86,6 +92,20 @@ async def async_setup_entry(hass: HomeAssistant, entry: ConfigEntry) -> bool:
|
|||||||
hass.data.setdefault(DOMAIN, {})[entry.entry_id] = coordinator
|
hass.data.setdefault(DOMAIN, {})[entry.entry_id] = coordinator
|
||||||
await hass.config_entries.async_forward_entry_setups(entry, PLATFORMS)
|
await hass.config_entries.async_forward_entry_setups(entry, PLATFORMS)
|
||||||
await async_setup_services(hass)
|
await async_setup_services(hass)
|
||||||
|
# Websocket commands are global (not per-entry) but the registration
|
||||||
|
# helper is idempotent, so calling it for each entry is harmless.
|
||||||
|
async_register_websocket_commands(hass)
|
||||||
|
# Panel registration must happen exactly once — guard with a flag in
|
||||||
|
# hass.data. The flag survives entry reloads; only a full HA restart
|
||||||
|
# clears it (matching when HA itself would need to re-register).
|
||||||
|
if not hass.data[DOMAIN].get(_PANEL_REGISTERED_KEY):
|
||||||
|
try:
|
||||||
|
await async_register_side_panel(hass)
|
||||||
|
except Exception:
|
||||||
|
LOGGER.warning(
|
||||||
|
"omni_pca: side panel registration failed", exc_info=True,
|
||||||
|
)
|
||||||
|
hass.data[DOMAIN][_PANEL_REGISTERED_KEY] = True
|
||||||
return True
|
return True
|
||||||
|
|
||||||
|
|
||||||
|
|||||||
@ -3,7 +3,7 @@
|
|||||||
"name": "HAI/Leviton Omni Panel",
|
"name": "HAI/Leviton Omni Panel",
|
||||||
"codeowners": ["@rsp2k"],
|
"codeowners": ["@rsp2k"],
|
||||||
"config_flow": true,
|
"config_flow": true,
|
||||||
"dependencies": [],
|
"dependencies": ["http", "websocket_api"],
|
||||||
"documentation": "https://github.com/rsp2k/omni-pca",
|
"documentation": "https://github.com/rsp2k/omni-pca",
|
||||||
"integration_type": "hub",
|
"integration_type": "hub",
|
||||||
"iot_class": "local_push",
|
"iot_class": "local_push",
|
||||||
|
|||||||
524
custom_components/omni_pca/websocket.py
Normal file
524
custom_components/omni_pca/websocket.py
Normal file
@ -0,0 +1,524 @@
|
|||||||
|
"""HA websocket commands for the program viewer.
|
||||||
|
|
||||||
|
The frontend talks to the integration via Home Assistant's standard
|
||||||
|
websocket API. We register three commands here, all namespaced under
|
||||||
|
``omni_pca/programs/``:
|
||||||
|
|
||||||
|
* ``omni_pca/programs/list`` — paginated, filterable summary list. Each
|
||||||
|
result row carries the token stream for the one-line summary plus the
|
||||||
|
metadata the frontend needs to filter and drill in.
|
||||||
|
* ``omni_pca/programs/get`` — full detail for a single slot. Returns
|
||||||
|
the structured-English token stream for the compact form or the
|
||||||
|
full clausal chain.
|
||||||
|
* ``omni_pca/programs/fire`` — send ``Command.EXECUTE_PROGRAM`` over
|
||||||
|
the wire to ask the panel to run a program now. Returns success/error.
|
||||||
|
|
||||||
|
All commands take an ``entry_id`` so multi-panel installs can address
|
||||||
|
the right coordinator. The frontend's panel UI uses HA's `<ha-conn>`
|
||||||
|
WS client; this module just produces JSON-safe dicts.
|
||||||
|
"""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
from dataclasses import asdict
|
||||||
|
from typing import TYPE_CHECKING, Any
|
||||||
|
|
||||||
|
import voluptuous as vol
|
||||||
|
from homeassistant.components import websocket_api
|
||||||
|
from homeassistant.core import HomeAssistant, callback
|
||||||
|
|
||||||
|
from omni_pca.commands import Command
|
||||||
|
from omni_pca.program_engine import ClausalChain, build_chains
|
||||||
|
from omni_pca.program_renderer import (
|
||||||
|
NameResolver,
|
||||||
|
ProgramRenderer,
|
||||||
|
StateResolver,
|
||||||
|
Token,
|
||||||
|
)
|
||||||
|
from omni_pca.programs import Program, ProgramType
|
||||||
|
|
||||||
|
from .const import DOMAIN
|
||||||
|
|
||||||
|
if TYPE_CHECKING:
|
||||||
|
from .coordinator import OmniDataUpdateCoordinator
|
||||||
|
|
||||||
|
|
||||||
|
# --------------------------------------------------------------------------
|
||||||
|
# Coordinator-backed resolvers
|
||||||
|
# --------------------------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
class _CoordinatorNameResolver:
|
||||||
|
"""Resolve object names from coordinator-discovered topology.
|
||||||
|
|
||||||
|
The coordinator's :class:`OmniData` stores ``zones`` / ``units`` /
|
||||||
|
``areas`` / ``thermostats`` / ``buttons`` as dicts of typed
|
||||||
|
properties dataclasses (each with a ``name`` attribute). For
|
||||||
|
``message`` / ``code`` / ``timeclock`` we don't track HA-side
|
||||||
|
properties — fall through to ``None`` so the renderer generates
|
||||||
|
``"Message 5"``-style labels.
|
||||||
|
"""
|
||||||
|
|
||||||
|
def __init__(self, coordinator: "OmniDataUpdateCoordinator") -> None:
|
||||||
|
self._coordinator = coordinator
|
||||||
|
|
||||||
|
def name_of(self, kind: str, index: int) -> str | None:
|
||||||
|
data = self._coordinator.data
|
||||||
|
if data is None:
|
||||||
|
return None
|
||||||
|
bucket = {
|
||||||
|
"zone": data.zones,
|
||||||
|
"unit": data.units,
|
||||||
|
"area": data.areas,
|
||||||
|
"thermostat": data.thermostats,
|
||||||
|
"button": data.buttons,
|
||||||
|
}.get(kind)
|
||||||
|
if bucket is None:
|
||||||
|
return None
|
||||||
|
props = bucket.get(index)
|
||||||
|
if props is None:
|
||||||
|
return None
|
||||||
|
return getattr(props, "name", None) or None
|
||||||
|
|
||||||
|
|
||||||
|
class _CoordinatorStateResolver:
|
||||||
|
"""Live-state overlay using the coordinator's *_status maps.
|
||||||
|
|
||||||
|
The status dicts update on every poll *and* are patched in-place
|
||||||
|
when the event listener decodes a push event, so each websocket
|
||||||
|
call sees the freshest available state without a round-trip to
|
||||||
|
the panel.
|
||||||
|
"""
|
||||||
|
|
||||||
|
_AREA_MODES: dict[int, str] = {
|
||||||
|
0: "Off", 1: "Day", 2: "Night", 3: "Away",
|
||||||
|
4: "Vacation", 5: "Day Instant", 6: "Night Delayed",
|
||||||
|
}
|
||||||
|
|
||||||
|
def __init__(self, coordinator: "OmniDataUpdateCoordinator") -> None:
|
||||||
|
self._coordinator = coordinator
|
||||||
|
|
||||||
|
def state_of(self, kind: str, index: int) -> str | None:
|
||||||
|
data = self._coordinator.data
|
||||||
|
if data is None:
|
||||||
|
return None
|
||||||
|
if kind == "zone":
|
||||||
|
status = data.zone_status.get(index)
|
||||||
|
if status is None:
|
||||||
|
return None
|
||||||
|
if status.is_bypassed:
|
||||||
|
return "BYPASSED"
|
||||||
|
return {0: "SECURE", 1: "NOT READY", 2: "TROUBLE", 3: "TAMPER"}.get(
|
||||||
|
status.current_state, f"state {status.current_state}",
|
||||||
|
)
|
||||||
|
if kind == "unit":
|
||||||
|
status = data.unit_status.get(index)
|
||||||
|
if status is None:
|
||||||
|
return None
|
||||||
|
if status.state == 0:
|
||||||
|
return "OFF"
|
||||||
|
if status.state >= 100:
|
||||||
|
return f"ON {status.state - 100}%"
|
||||||
|
return "ON"
|
||||||
|
if kind == "area":
|
||||||
|
status = data.area_status.get(index)
|
||||||
|
if status is None:
|
||||||
|
return None
|
||||||
|
return self._AREA_MODES.get(status.mode, f"mode {status.mode}")
|
||||||
|
if kind == "thermostat":
|
||||||
|
status = data.thermostat_status.get(index)
|
||||||
|
if status is None or status.temperature_raw == 0:
|
||||||
|
return None
|
||||||
|
return f"{status.temperature_raw // 2 - 40}°F"
|
||||||
|
return None
|
||||||
|
|
||||||
|
|
||||||
|
# --------------------------------------------------------------------------
|
||||||
|
# Token serialisation + reference extraction
|
||||||
|
# --------------------------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
def _tokens_to_json(tokens: list[Token]) -> list[dict[str, Any]]:
|
||||||
|
"""Serialise a Token list to plain dicts the websocket layer can JSON.
|
||||||
|
|
||||||
|
``dataclasses.asdict`` would also work but produces ``None`` keys for
|
||||||
|
fields irrelevant to the token's kind; we omit those explicitly so
|
||||||
|
the wire format stays compact and the frontend sees clean shapes.
|
||||||
|
"""
|
||||||
|
out: list[dict[str, Any]] = []
|
||||||
|
for t in tokens:
|
||||||
|
d: dict[str, Any] = {"k": t.kind, "t": t.text}
|
||||||
|
if t.entity_kind is not None:
|
||||||
|
d["ek"] = t.entity_kind
|
||||||
|
if t.entity_id is not None:
|
||||||
|
d["ei"] = t.entity_id
|
||||||
|
if t.state is not None:
|
||||||
|
d["s"] = t.state
|
||||||
|
out.append(d)
|
||||||
|
return out
|
||||||
|
|
||||||
|
|
||||||
|
def _extract_references(tokens: list[Token]) -> list[str]:
|
||||||
|
"""Collect distinct ``"<kind>:<id>"`` references from a token stream.
|
||||||
|
|
||||||
|
Used to populate each list-row's ``references`` field so the
|
||||||
|
frontend can filter on "involves this entity" without re-parsing
|
||||||
|
the tokens. Returns a deduplicated, stable-ordered list.
|
||||||
|
"""
|
||||||
|
seen: dict[str, None] = {}
|
||||||
|
for t in tokens:
|
||||||
|
if t.entity_kind and t.entity_id is not None:
|
||||||
|
seen[f"{t.entity_kind}:{t.entity_id}"] = None
|
||||||
|
return list(seen.keys())
|
||||||
|
|
||||||
|
|
||||||
|
# --------------------------------------------------------------------------
|
||||||
|
# Helper: pick a coordinator + build the renderer
|
||||||
|
# --------------------------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
def _coordinator_for_entry(
|
||||||
|
hass: HomeAssistant, entry_id: str,
|
||||||
|
) -> "OmniDataUpdateCoordinator | None":
|
||||||
|
return hass.data.get(DOMAIN, {}).get(entry_id)
|
||||||
|
|
||||||
|
|
||||||
|
def _build_renderer(coordinator: "OmniDataUpdateCoordinator") -> ProgramRenderer:
|
||||||
|
return ProgramRenderer(
|
||||||
|
names=_CoordinatorNameResolver(coordinator),
|
||||||
|
state=_CoordinatorStateResolver(coordinator),
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
def _classify_trigger(p: Program) -> str:
|
||||||
|
"""Stable string label for the trigger type — used in filter chips."""
|
||||||
|
try:
|
||||||
|
return ProgramType(p.prog_type).name
|
||||||
|
except ValueError:
|
||||||
|
return f"UNKNOWN_{p.prog_type}"
|
||||||
|
|
||||||
|
|
||||||
|
# --------------------------------------------------------------------------
|
||||||
|
# Websocket commands
|
||||||
|
# --------------------------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
@websocket_api.websocket_command(
|
||||||
|
{
|
||||||
|
vol.Required("type"): "omni_pca/programs/list",
|
||||||
|
vol.Required("entry_id"): str,
|
||||||
|
vol.Optional("trigger_types"): [str],
|
||||||
|
vol.Optional("references_entity"): str, # e.g. "zone:5"
|
||||||
|
vol.Optional("search"): str,
|
||||||
|
vol.Optional("limit"): vol.All(int, vol.Range(min=1, max=1500)),
|
||||||
|
vol.Optional("offset"): vol.All(int, vol.Range(min=0)),
|
||||||
|
}
|
||||||
|
)
|
||||||
|
@websocket_api.async_response
|
||||||
|
async def _ws_list_programs(
|
||||||
|
hass: HomeAssistant,
|
||||||
|
connection: websocket_api.ActiveConnection,
|
||||||
|
msg: dict[str, Any],
|
||||||
|
) -> None:
|
||||||
|
"""Paginated list of programs with filters applied.
|
||||||
|
|
||||||
|
Returns rows containing the one-line summary tokens plus the
|
||||||
|
metadata needed for filter UI (trigger type, references). The
|
||||||
|
frontend renders the summary inline; clicking a row triggers a
|
||||||
|
follow-up ``programs/get`` for the full detail.
|
||||||
|
"""
|
||||||
|
coordinator = _coordinator_for_entry(hass, msg["entry_id"])
|
||||||
|
if coordinator is None:
|
||||||
|
connection.send_error(msg["id"], "not_found", "panel not configured")
|
||||||
|
return
|
||||||
|
|
||||||
|
renderer = _build_renderer(coordinator)
|
||||||
|
programs = coordinator.data.programs if coordinator.data else {}
|
||||||
|
# Clausal chains span multiple slots — group them so each chain
|
||||||
|
# appears once instead of one row per slot.
|
||||||
|
chains_by_head_slot = {
|
||||||
|
c.head.slot: c for c in build_chains(tuple(programs.values()))
|
||||||
|
}
|
||||||
|
consumed_chain_slots: set[int] = set()
|
||||||
|
for chain in chains_by_head_slot.values():
|
||||||
|
if chain.head.slot is not None:
|
||||||
|
consumed_chain_slots.add(chain.head.slot)
|
||||||
|
for cond in chain.conditions:
|
||||||
|
if cond.slot is not None:
|
||||||
|
consumed_chain_slots.add(cond.slot)
|
||||||
|
for action in chain.actions:
|
||||||
|
if action.slot is not None:
|
||||||
|
consumed_chain_slots.add(action.slot)
|
||||||
|
|
||||||
|
rows: list[dict[str, Any]] = []
|
||||||
|
for slot in sorted(programs):
|
||||||
|
if slot in chains_by_head_slot:
|
||||||
|
chain = chains_by_head_slot[slot]
|
||||||
|
summary = renderer.summarize_chain(chain)
|
||||||
|
rows.append({
|
||||||
|
"slot": slot,
|
||||||
|
"kind": "chain",
|
||||||
|
"trigger_type": _classify_trigger(chain.head),
|
||||||
|
"summary": _tokens_to_json(summary),
|
||||||
|
"references": _extract_references(summary),
|
||||||
|
"condition_count": len(chain.conditions),
|
||||||
|
"action_count": len(chain.actions),
|
||||||
|
})
|
||||||
|
continue
|
||||||
|
if slot in consumed_chain_slots:
|
||||||
|
continue # part of a chain we already rendered
|
||||||
|
program = programs[slot]
|
||||||
|
summary = renderer.summarize_program(program)
|
||||||
|
rows.append({
|
||||||
|
"slot": slot,
|
||||||
|
"kind": "compact",
|
||||||
|
"trigger_type": _classify_trigger(program),
|
||||||
|
"summary": _tokens_to_json(summary),
|
||||||
|
"references": _extract_references(summary),
|
||||||
|
"condition_count": (1 if program.cond else 0) + (1 if program.cond2 else 0),
|
||||||
|
"action_count": 1,
|
||||||
|
})
|
||||||
|
|
||||||
|
# Filtering happens after rendering so the filter UI can use the
|
||||||
|
# final, name-resolved text. Trade-off: O(N) per request even when
|
||||||
|
# filters narrow the result; with N ≤ 1500 this is fine in practice.
|
||||||
|
trigger_types: list[str] | None = msg.get("trigger_types")
|
||||||
|
references_entity: str | None = msg.get("references_entity")
|
||||||
|
search: str | None = msg.get("search")
|
||||||
|
if search:
|
||||||
|
search_lower = search.lower()
|
||||||
|
filtered = []
|
||||||
|
for row in rows:
|
||||||
|
if trigger_types and row["trigger_type"] not in trigger_types:
|
||||||
|
continue
|
||||||
|
if references_entity and references_entity not in row["references"]:
|
||||||
|
continue
|
||||||
|
if search:
|
||||||
|
row_text = "".join(
|
||||||
|
tok["t"] for tok in row["summary"] if tok.get("k") != "newline"
|
||||||
|
).lower()
|
||||||
|
if search_lower not in row_text:
|
||||||
|
continue
|
||||||
|
filtered.append(row)
|
||||||
|
|
||||||
|
total = len(rows)
|
||||||
|
filtered_total = len(filtered)
|
||||||
|
offset = msg.get("offset", 0)
|
||||||
|
limit = msg.get("limit", 200)
|
||||||
|
page = filtered[offset : offset + limit]
|
||||||
|
|
||||||
|
connection.send_result(msg["id"], {
|
||||||
|
"programs": page,
|
||||||
|
"total": total,
|
||||||
|
"filtered_total": filtered_total,
|
||||||
|
"offset": offset,
|
||||||
|
"limit": limit,
|
||||||
|
})
|
||||||
|
|
||||||
|
|
||||||
|
@websocket_api.websocket_command(
|
||||||
|
{
|
||||||
|
vol.Required("type"): "omni_pca/programs/get",
|
||||||
|
vol.Required("entry_id"): str,
|
||||||
|
vol.Required("slot"): vol.All(int, vol.Range(min=1, max=1500)),
|
||||||
|
}
|
||||||
|
)
|
||||||
|
@websocket_api.async_response
|
||||||
|
async def _ws_get_program(
|
||||||
|
hass: HomeAssistant,
|
||||||
|
connection: websocket_api.ActiveConnection,
|
||||||
|
msg: dict[str, Any],
|
||||||
|
) -> None:
|
||||||
|
"""Full structured-English detail for one slot.
|
||||||
|
|
||||||
|
If the requested slot is the head of a clausal chain we return the
|
||||||
|
rendered chain; if it's a continuation slot (an AND/OR/THEN in the
|
||||||
|
middle of a chain) we still return the chain that contains it, so
|
||||||
|
the frontend always shows the complete program even when the user
|
||||||
|
clicks an interior slot.
|
||||||
|
"""
|
||||||
|
coordinator = _coordinator_for_entry(hass, msg["entry_id"])
|
||||||
|
if coordinator is None:
|
||||||
|
connection.send_error(msg["id"], "not_found", "panel not configured")
|
||||||
|
return
|
||||||
|
|
||||||
|
renderer = _build_renderer(coordinator)
|
||||||
|
programs = coordinator.data.programs if coordinator.data else {}
|
||||||
|
target = programs.get(msg["slot"])
|
||||||
|
if target is None:
|
||||||
|
connection.send_error(msg["id"], "not_found", "no program at that slot")
|
||||||
|
return
|
||||||
|
|
||||||
|
chains = build_chains(tuple(programs.values()))
|
||||||
|
containing_chain: ClausalChain | None = None
|
||||||
|
for chain in chains:
|
||||||
|
members = (
|
||||||
|
(chain.head,) + chain.conditions + chain.actions
|
||||||
|
)
|
||||||
|
if any(m.slot == msg["slot"] for m in members):
|
||||||
|
containing_chain = chain
|
||||||
|
break
|
||||||
|
|
||||||
|
if containing_chain is not None:
|
||||||
|
tokens = renderer.render_chain(containing_chain)
|
||||||
|
connection.send_result(msg["id"], {
|
||||||
|
"slot": containing_chain.head.slot,
|
||||||
|
"kind": "chain",
|
||||||
|
"trigger_type": _classify_trigger(containing_chain.head),
|
||||||
|
"tokens": _tokens_to_json(tokens),
|
||||||
|
"references": _extract_references(tokens),
|
||||||
|
"chain_slots": [m.slot for m in members if m.slot is not None],
|
||||||
|
})
|
||||||
|
return
|
||||||
|
|
||||||
|
tokens = renderer.render_program(target)
|
||||||
|
connection.send_result(msg["id"], {
|
||||||
|
"slot": msg["slot"],
|
||||||
|
"kind": "compact",
|
||||||
|
"trigger_type": _classify_trigger(target),
|
||||||
|
"tokens": _tokens_to_json(tokens),
|
||||||
|
"references": _extract_references(tokens),
|
||||||
|
})
|
||||||
|
|
||||||
|
|
||||||
|
@websocket_api.websocket_command(
|
||||||
|
{
|
||||||
|
vol.Required("type"): "omni_pca/programs/fire",
|
||||||
|
vol.Required("entry_id"): str,
|
||||||
|
vol.Required("slot"): vol.All(int, vol.Range(min=1, max=1500)),
|
||||||
|
}
|
||||||
|
)
|
||||||
|
@websocket_api.async_response
|
||||||
|
async def _ws_fire_program(
|
||||||
|
hass: HomeAssistant,
|
||||||
|
connection: websocket_api.ActiveConnection,
|
||||||
|
msg: dict[str, Any],
|
||||||
|
) -> None:
|
||||||
|
"""Ask the panel to execute a program right now.
|
||||||
|
|
||||||
|
Sends ``Command(EXECUTE_PROGRAM, parameter2=slot)`` via the
|
||||||
|
coordinator's :class:`OmniClient`. The panel acks; any state
|
||||||
|
changes the program triggers come back as ordinary push events.
|
||||||
|
"""
|
||||||
|
coordinator = _coordinator_for_entry(hass, msg["entry_id"])
|
||||||
|
if coordinator is None:
|
||||||
|
connection.send_error(msg["id"], "not_found", "panel not configured")
|
||||||
|
return
|
||||||
|
try:
|
||||||
|
client = coordinator.client
|
||||||
|
except RuntimeError as err:
|
||||||
|
connection.send_error(msg["id"], "not_connected", str(err))
|
||||||
|
return
|
||||||
|
try:
|
||||||
|
await client.execute_command(Command.EXECUTE_PROGRAM, parameter2=msg["slot"])
|
||||||
|
except Exception as err:
|
||||||
|
connection.send_error(msg["id"], "fire_failed", str(err))
|
||||||
|
return
|
||||||
|
connection.send_result(msg["id"], {"slot": msg["slot"], "fired": True})
|
||||||
|
|
||||||
|
|
||||||
|
# --------------------------------------------------------------------------
|
||||||
|
# Setup
|
||||||
|
# --------------------------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
@callback
|
||||||
|
def async_register_websocket_commands(hass: HomeAssistant) -> None:
|
||||||
|
"""Idempotently register the program-viewer websocket commands.
|
||||||
|
|
||||||
|
Called from the integration's ``async_setup_entry``; safe to call
|
||||||
|
once per HA boot. HA's ``websocket_api.async_register_command`` is
|
||||||
|
itself idempotent so a stray double-call from reload paths is fine.
|
||||||
|
"""
|
||||||
|
websocket_api.async_register_command(hass, _ws_list_programs)
|
||||||
|
websocket_api.async_register_command(hass, _ws_get_program)
|
||||||
|
websocket_api.async_register_command(hass, _ws_fire_program)
|
||||||
|
|
||||||
|
|
||||||
|
# --------------------------------------------------------------------------
|
||||||
|
# Side-panel registration
|
||||||
|
# --------------------------------------------------------------------------
|
||||||
|
|
||||||
|
|
||||||
|
# Where the integration serves the bundled panel JS from. Phase C builds
|
||||||
|
# the actual ESM bundle and drops it at ``custom_components/omni_pca/
|
||||||
|
# www/panel.js`` — we register a static path so HA serves it at
|
||||||
|
# ``/api/omni_pca/panel.js``.
|
||||||
|
_PANEL_FRONTEND_URL: str = "omni-panel-programs"
|
||||||
|
_PANEL_WEBCOMPONENT: str = "omni-panel-programs"
|
||||||
|
_PANEL_JS_PATH: str = "/api/omni_pca/panel.js"
|
||||||
|
|
||||||
|
|
||||||
|
async def async_register_side_panel(hass: HomeAssistant) -> None:
|
||||||
|
"""Register the sidebar entry that hosts the program viewer.
|
||||||
|
|
||||||
|
The bundled panel JS is served from the integration's ``www/``
|
||||||
|
directory via a registered static path. Until Phase C ships the
|
||||||
|
bundle, the panel registration still appears (HA shows a generic
|
||||||
|
loader) so the wiring can be exercised end-to-end.
|
||||||
|
"""
|
||||||
|
from pathlib import Path
|
||||||
|
|
||||||
|
from homeassistant.components.frontend import (
|
||||||
|
async_remove_panel,
|
||||||
|
)
|
||||||
|
from homeassistant.components.panel_custom import async_register_panel
|
||||||
|
|
||||||
|
# Serve <integration>/www/panel.js at /api/omni_pca/panel.js.
|
||||||
|
www_dir = Path(__file__).parent / "www"
|
||||||
|
www_dir.mkdir(exist_ok=True)
|
||||||
|
panel_js = www_dir / "panel.js"
|
||||||
|
if not panel_js.exists():
|
||||||
|
# Stub so the static path resolves even before Phase C builds the
|
||||||
|
# real bundle. The stub renders a "panel coming soon" message so
|
||||||
|
# users on dev installs see something useful rather than 404.
|
||||||
|
panel_js.write_text(_STUB_PANEL_JS)
|
||||||
|
await hass.http.async_register_static_paths(
|
||||||
|
[_StaticPathConfig(_PANEL_JS_PATH, str(panel_js), False)]
|
||||||
|
)
|
||||||
|
|
||||||
|
# async_remove_panel before re-register so reload doesn't duplicate.
|
||||||
|
try:
|
||||||
|
async_remove_panel(hass, _PANEL_FRONTEND_URL)
|
||||||
|
except Exception:
|
||||||
|
pass
|
||||||
|
await async_register_panel(
|
||||||
|
hass,
|
||||||
|
frontend_url_path=_PANEL_FRONTEND_URL,
|
||||||
|
webcomponent_name=_PANEL_WEBCOMPONENT,
|
||||||
|
sidebar_title="Omni Programs",
|
||||||
|
sidebar_icon="mdi:script-text-outline",
|
||||||
|
module_url=_PANEL_JS_PATH,
|
||||||
|
embed_iframe=False,
|
||||||
|
require_admin=False,
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
_STUB_PANEL_JS: str = """\
|
||||||
|
// omni-pca side panel — stub until Phase C frontend lands.
|
||||||
|
class OmniPanelPrograms extends HTMLElement {
|
||||||
|
set hass(hass) {
|
||||||
|
if (!this._rendered) {
|
||||||
|
this.innerHTML = `
|
||||||
|
<style>
|
||||||
|
:host, .root { display: block; padding: 24px; font-family: sans-serif; }
|
||||||
|
h1 { font-size: 1.25rem; margin: 0 0 8px; }
|
||||||
|
p { color: #666; margin: 0; }
|
||||||
|
</style>
|
||||||
|
<div class="root">
|
||||||
|
<h1>Omni Programs</h1>
|
||||||
|
<p>Frontend bundle not yet installed.
|
||||||
|
Phase C of the program viewer will populate this panel.</p>
|
||||||
|
</div>`;
|
||||||
|
this._rendered = true;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
customElements.define('omni-panel-programs', OmniPanelPrograms);
|
||||||
|
"""
|
||||||
|
|
||||||
|
|
||||||
|
# Late import: HA's StaticPathConfig moved in 2024.7. The integration is
|
||||||
|
# pinned to a current HA release so this import works, but importing at
|
||||||
|
# module top would force the dep on tests that don't need the panel.
|
||||||
|
from homeassistant.components.http import StaticPathConfig as _StaticPathConfig # noqa: E402
|
||||||
20
custom_components/omni_pca/www/panel.js
Normal file
20
custom_components/omni_pca/www/panel.js
Normal file
@ -0,0 +1,20 @@
|
|||||||
|
// omni-pca side panel — stub until Phase C frontend lands.
|
||||||
|
class OmniPanelPrograms extends HTMLElement {
|
||||||
|
set hass(hass) {
|
||||||
|
if (!this._rendered) {
|
||||||
|
this.innerHTML = `
|
||||||
|
<style>
|
||||||
|
:host, .root { display: block; padding: 24px; font-family: sans-serif; }
|
||||||
|
h1 { font-size: 1.25rem; margin: 0 0 8px; }
|
||||||
|
p { color: #666; margin: 0; }
|
||||||
|
</style>
|
||||||
|
<div class="root">
|
||||||
|
<h1>Omni Programs</h1>
|
||||||
|
<p>Frontend bundle not yet installed.
|
||||||
|
Phase C of the program viewer will populate this panel.</p>
|
||||||
|
</div>`;
|
||||||
|
this._rendered = true;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
customElements.define('omni-panel-programs', OmniPanelPrograms);
|
||||||
265
tests/ha_integration/test_program_websocket.py
Normal file
265
tests/ha_integration/test_program_websocket.py
Normal file
@ -0,0 +1,265 @@
|
|||||||
|
"""HA websocket commands for the program viewer.
|
||||||
|
|
||||||
|
Tests run against the live HA test harness so they exercise:
|
||||||
|
* websocket command registration during integration setup
|
||||||
|
* filter / pagination / search of the program list
|
||||||
|
* detail rendering for compact-form + clausal-chain slots
|
||||||
|
* fire-program over the wire to the mock panel
|
||||||
|
|
||||||
|
Each test uses the already-seeded ``configured_panel`` fixture from
|
||||||
|
conftest.py plus the test-harness-provided ``hass_ws_client``.
|
||||||
|
"""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import pytest
|
||||||
|
from custom_components.omni_pca.const import DOMAIN
|
||||||
|
from homeassistant.core import HomeAssistant
|
||||||
|
|
||||||
|
from omni_pca.commands import Command
|
||||||
|
from omni_pca.programs import Days, Program, ProgramType
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def seeded_programs() -> dict[int, Program]:
|
||||||
|
"""A small set of programs covering the main shapes the viewer renders.
|
||||||
|
|
||||||
|
Three compact-form TIMED programs and one clausal chain — enough
|
||||||
|
to exercise summary rendering, the chain group-and-render path, and
|
||||||
|
the filter/search dimensions.
|
||||||
|
"""
|
||||||
|
return {
|
||||||
|
12: Program(
|
||||||
|
slot=12, prog_type=int(ProgramType.TIMED),
|
||||||
|
cmd=int(Command.UNIT_ON), pr2=1, # unit 1 in fixture
|
||||||
|
hour=6, minute=0, days=int(Days.MONDAY | Days.FRIDAY),
|
||||||
|
),
|
||||||
|
42: Program(
|
||||||
|
slot=42, prog_type=int(ProgramType.TIMED),
|
||||||
|
cmd=int(Command.UNIT_ON), pr2=2, # unit 2
|
||||||
|
hour=22, minute=30, days=int(Days.SUNDAY),
|
||||||
|
),
|
||||||
|
99: Program(
|
||||||
|
slot=99, prog_type=int(ProgramType.EVENT),
|
||||||
|
cmd=int(Command.UNIT_ON), pr2=1,
|
||||||
|
# WHEN zone 1 changes to NOT_READY (event_id = 0x0401)
|
||||||
|
month=0x04, day=0x01,
|
||||||
|
),
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def populated_state(seeded_programs):
|
||||||
|
"""Override the conftest fixture to inject our test programs."""
|
||||||
|
from omni_pca.mock_panel import (
|
||||||
|
MockAreaState,
|
||||||
|
MockButtonState,
|
||||||
|
MockState,
|
||||||
|
MockThermostatState,
|
||||||
|
MockUnitState,
|
||||||
|
MockZoneState,
|
||||||
|
)
|
||||||
|
|
||||||
|
return MockState(
|
||||||
|
zones={
|
||||||
|
1: MockZoneState(name="FRONT_DOOR"),
|
||||||
|
2: MockZoneState(name="GARAGE_ENTRY"),
|
||||||
|
10: MockZoneState(name="LIVING_MOTION"),
|
||||||
|
},
|
||||||
|
units={
|
||||||
|
1: MockUnitState(name="LIVING_LAMP"),
|
||||||
|
2: MockUnitState(name="KITCHEN_OVERHEAD"),
|
||||||
|
},
|
||||||
|
areas={1: MockAreaState(name="MAIN")},
|
||||||
|
thermostats={1: MockThermostatState(name="LIVING_ROOM")},
|
||||||
|
buttons={1: MockButtonState(name="GOOD_MORNING")},
|
||||||
|
user_codes={1: 1234},
|
||||||
|
programs={
|
||||||
|
slot: p.encode_wire_bytes() for slot, p in seeded_programs.items()
|
||||||
|
},
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
async def test_ws_list_programs_returns_summaries(
|
||||||
|
hass: HomeAssistant, configured_panel, hass_ws_client
|
||||||
|
) -> None:
|
||||||
|
"""The list command returns rendered summary tokens for every
|
||||||
|
program the coordinator discovered."""
|
||||||
|
client = await hass_ws_client(hass)
|
||||||
|
await client.send_json_auto_id({
|
||||||
|
"type": "omni_pca/programs/list",
|
||||||
|
"entry_id": configured_panel.entry_id,
|
||||||
|
})
|
||||||
|
response = await client.receive_json()
|
||||||
|
assert response["success"] is True
|
||||||
|
result = response["result"]
|
||||||
|
assert result["total"] == 3
|
||||||
|
assert result["filtered_total"] == 3
|
||||||
|
rows_by_slot = {row["slot"]: row for row in result["programs"]}
|
||||||
|
# Both TIMED programs and the EVENT program land in the response.
|
||||||
|
assert rows_by_slot.keys() == {12, 42, 99}
|
||||||
|
# Each row has the metadata the frontend needs.
|
||||||
|
for row in result["programs"]:
|
||||||
|
assert row["kind"] == "compact"
|
||||||
|
assert row["trigger_type"] in ("TIMED", "EVENT")
|
||||||
|
assert isinstance(row["summary"], list)
|
||||||
|
assert row["summary"] # non-empty token list
|
||||||
|
|
||||||
|
|
||||||
|
async def test_ws_list_programs_filter_by_trigger_type(
|
||||||
|
hass: HomeAssistant, configured_panel, hass_ws_client
|
||||||
|
) -> None:
|
||||||
|
"""``trigger_types=["TIMED"]`` filters out the EVENT-typed row."""
|
||||||
|
client = await hass_ws_client(hass)
|
||||||
|
await client.send_json_auto_id({
|
||||||
|
"type": "omni_pca/programs/list",
|
||||||
|
"entry_id": configured_panel.entry_id,
|
||||||
|
"trigger_types": ["TIMED"],
|
||||||
|
})
|
||||||
|
response = await client.receive_json()
|
||||||
|
assert response["success"] is True
|
||||||
|
result = response["result"]
|
||||||
|
assert result["filtered_total"] == 2 # only the two TIMED rows
|
||||||
|
assert {row["slot"] for row in result["programs"]} == {12, 42}
|
||||||
|
|
||||||
|
|
||||||
|
async def test_ws_list_programs_filter_by_referenced_entity(
|
||||||
|
hass: HomeAssistant, configured_panel, hass_ws_client
|
||||||
|
) -> None:
|
||||||
|
"""``references_entity="unit:2"`` returns only programs that mention unit 2."""
|
||||||
|
client = await hass_ws_client(hass)
|
||||||
|
await client.send_json_auto_id({
|
||||||
|
"type": "omni_pca/programs/list",
|
||||||
|
"entry_id": configured_panel.entry_id,
|
||||||
|
"references_entity": "unit:2",
|
||||||
|
})
|
||||||
|
response = await client.receive_json()
|
||||||
|
result = response["result"]
|
||||||
|
assert result["filtered_total"] == 1
|
||||||
|
assert result["programs"][0]["slot"] == 42
|
||||||
|
|
||||||
|
|
||||||
|
async def test_ws_list_programs_search_substring(
|
||||||
|
hass: HomeAssistant, configured_panel, hass_ws_client
|
||||||
|
) -> None:
|
||||||
|
"""Search is a case-insensitive substring match on the rendered text."""
|
||||||
|
client = await hass_ws_client(hass)
|
||||||
|
await client.send_json_auto_id({
|
||||||
|
"type": "omni_pca/programs/list",
|
||||||
|
"entry_id": configured_panel.entry_id,
|
||||||
|
"search": "kitchen",
|
||||||
|
})
|
||||||
|
response = await client.receive_json()
|
||||||
|
result = response["result"]
|
||||||
|
# Only slot 42 ("Turn ON KITCHEN_OVERHEAD") mentions kitchen.
|
||||||
|
assert result["filtered_total"] == 1
|
||||||
|
assert result["programs"][0]["slot"] == 42
|
||||||
|
|
||||||
|
|
||||||
|
async def test_ws_list_programs_pagination(
|
||||||
|
hass: HomeAssistant, configured_panel, hass_ws_client
|
||||||
|
) -> None:
|
||||||
|
client = await hass_ws_client(hass)
|
||||||
|
await client.send_json_auto_id({
|
||||||
|
"type": "omni_pca/programs/list",
|
||||||
|
"entry_id": configured_panel.entry_id,
|
||||||
|
"limit": 2,
|
||||||
|
"offset": 1,
|
||||||
|
})
|
||||||
|
response = await client.receive_json()
|
||||||
|
result = response["result"]
|
||||||
|
assert result["filtered_total"] == 3
|
||||||
|
assert len(result["programs"]) == 2
|
||||||
|
assert [row["slot"] for row in result["programs"]] == [42, 99]
|
||||||
|
|
||||||
|
|
||||||
|
async def test_ws_get_program_returns_full_token_stream(
|
||||||
|
hass: HomeAssistant, configured_panel, hass_ws_client
|
||||||
|
) -> None:
|
||||||
|
"""Detail of a single slot returns the full structured-English tokens."""
|
||||||
|
client = await hass_ws_client(hass)
|
||||||
|
await client.send_json_auto_id({
|
||||||
|
"type": "omni_pca/programs/get",
|
||||||
|
"entry_id": configured_panel.entry_id,
|
||||||
|
"slot": 42,
|
||||||
|
})
|
||||||
|
response = await client.receive_json()
|
||||||
|
assert response["success"] is True
|
||||||
|
result = response["result"]
|
||||||
|
assert result["slot"] == 42
|
||||||
|
assert result["kind"] == "compact"
|
||||||
|
assert result["trigger_type"] == "TIMED"
|
||||||
|
text = "".join(
|
||||||
|
tok["t"] for tok in result["tokens"] if tok.get("k") != "newline"
|
||||||
|
)
|
||||||
|
assert "Turn ON" in text
|
||||||
|
# Unit names cap at 12 bytes on Omni Pro II (lenUnitName), so the
|
||||||
|
# 16-char "KITCHEN_OVERHEAD" lands on the wire as "KITCHEN_OVER".
|
||||||
|
assert "KITCHEN_OVER" in text
|
||||||
|
|
||||||
|
|
||||||
|
async def test_ws_get_program_missing_slot_returns_error(
|
||||||
|
hass: HomeAssistant, configured_panel, hass_ws_client
|
||||||
|
) -> None:
|
||||||
|
client = await hass_ws_client(hass)
|
||||||
|
await client.send_json_auto_id({
|
||||||
|
"type": "omni_pca/programs/get",
|
||||||
|
"entry_id": configured_panel.entry_id,
|
||||||
|
"slot": 500, # not seeded
|
||||||
|
})
|
||||||
|
response = await client.receive_json()
|
||||||
|
assert response["success"] is False
|
||||||
|
assert response["error"]["code"] == "not_found"
|
||||||
|
|
||||||
|
|
||||||
|
async def test_ws_list_programs_unknown_entry_id(
|
||||||
|
hass: HomeAssistant, configured_panel, hass_ws_client
|
||||||
|
) -> None:
|
||||||
|
"""Bad entry_id returns a structured ``not_found`` error, not a crash."""
|
||||||
|
client = await hass_ws_client(hass)
|
||||||
|
await client.send_json_auto_id({
|
||||||
|
"type": "omni_pca/programs/list",
|
||||||
|
"entry_id": "does-not-exist",
|
||||||
|
})
|
||||||
|
response = await client.receive_json()
|
||||||
|
assert response["success"] is False
|
||||||
|
assert response["error"]["code"] == "not_found"
|
||||||
|
|
||||||
|
|
||||||
|
async def test_ws_fire_program_executes_command(
|
||||||
|
hass: HomeAssistant, configured_panel, hass_ws_client
|
||||||
|
) -> None:
|
||||||
|
"""Fire sends Command.EXECUTE_PROGRAM over the wire — the mock acks."""
|
||||||
|
client = await hass_ws_client(hass)
|
||||||
|
await client.send_json_auto_id({
|
||||||
|
"type": "omni_pca/programs/fire",
|
||||||
|
"entry_id": configured_panel.entry_id,
|
||||||
|
"slot": 42,
|
||||||
|
})
|
||||||
|
response = await client.receive_json()
|
||||||
|
assert response["success"] is True
|
||||||
|
assert response["result"] == {"slot": 42, "fired": True}
|
||||||
|
|
||||||
|
|
||||||
|
async def test_ws_list_programs_live_state_overlay_zone(
|
||||||
|
hass: HomeAssistant, configured_panel, hass_ws_client
|
||||||
|
) -> None:
|
||||||
|
"""Summary tokens carry live-state badges on REF tokens.
|
||||||
|
|
||||||
|
The EVENT program at slot 99 references zone 1; the coordinator's
|
||||||
|
``zone_status[1]`` carries SECURE / NOT READY etc. and we expect
|
||||||
|
that label to flow through to the token's ``s`` field.
|
||||||
|
"""
|
||||||
|
client = await hass_ws_client(hass)
|
||||||
|
await client.send_json_auto_id({
|
||||||
|
"type": "omni_pca/programs/list",
|
||||||
|
"entry_id": configured_panel.entry_id,
|
||||||
|
})
|
||||||
|
response = await client.receive_json()
|
||||||
|
rows_by_slot = {row["slot"]: row for row in response["result"]["programs"]}
|
||||||
|
event_row = rows_by_slot[99]
|
||||||
|
refs = [tok for tok in event_row["summary"] if tok.get("k") == "ref"]
|
||||||
|
# At least one REF should be the zone-1 reference with a state label.
|
||||||
|
zone_refs = [r for r in refs if r.get("ek") == "zone" and r.get("ei") == 1]
|
||||||
|
assert zone_refs, f"expected zone:1 ref in {refs!r}"
|
||||||
|
assert "s" in zone_refs[0] # state badge populated
|
||||||
Loading…
x
Reference in New Issue
Block a user