From d2f8034961b1915e899c42f1e57ace766b31526e Mon Sep 17 00:00:00 2001 From: KV Date: Sat, 14 Nov 2020 21:37:31 +0100 Subject: [PATCH] Simplify collecting designators for a joined BOM entry Assign input designators once to a temporary variable for easy reusage. --- src/wireviz/wv_bom.py | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/wireviz/wv_bom.py b/src/wireviz/wv_bom.py index e9fc478..c27a204 100644 --- a/src/wireviz/wv_bom.py +++ b/src/wireviz/wv_bom.py @@ -106,11 +106,8 @@ def generate_bom(harness): group_entries = [v for v in bom_entries if bom_types_group(v) == group] designators = [] for group_entry in group_entries: - if group_entry.get('designators'): - if isinstance(group_entry['designators'], List): - designators.extend(group_entry['designators']) - else: - designators.append(group_entry['designators']) + d = group_entry.get('designators') + designators.extend(d if isinstance(d, List) else [d] if d else []) designators = list(dict.fromkeys(designators)) # remove duplicates designators.sort() total_qty = sum(entry['qty'] for entry in group_entries)