From 0fed30aa05e96b2ba6dd4e6a98fd752db9d69f74 Mon Sep 17 00:00:00 2001 From: Daniel Rojas Date: Sat, 1 Mar 2025 17:32:48 +0100 Subject: [PATCH] Apply suggestions from code review Co-authored-by: kvid --- docs/README.md | 2 +- src/wireviz/wv_cli.py | 6 +++++- src/wireviz/wv_colors.py | 2 +- src/wireviz/wv_dataclasses.py | 2 +- 4 files changed, 8 insertions(+), 4 deletions(-) diff --git a/docs/README.md b/docs/README.md index 4fa5159..5e14600 100644 --- a/docs/README.md +++ b/docs/README.md @@ -137,7 +137,7 @@ mywire.tsv BOM (bill of materials) as tab-separated text file mywire.html HTML page with wiring diagram and BOM embedded ``` -Wildcars in the file path are also supported to process multiple files at once, e.g.: +Wildcards in the file path are also supported to process multiple files at once, e.g.: ``` $ wireviz ~/path/to/files/*.yml ``` diff --git a/src/wireviz/wv_cli.py b/src/wireviz/wv_cli.py index 7acff8a..4c6ac8f 100644 --- a/src/wireviz/wv_cli.py +++ b/src/wireviz/wv_cli.py @@ -31,7 +31,11 @@ epilog = ( ) -@click.command(epilog=epilog, no_args_is_help=True) +@click.command( + epilog=epilog, + no_args_is_help=True, + context_settings=dict(help_option_names=["-h", "--help"]), +) @click.argument("file", nargs=-1) @click.option( "-f", diff --git a/src/wireviz/wv_colors.py b/src/wireviz/wv_colors.py index 876a030..f7247b7 100644 --- a/src/wireviz/wv_colors.py +++ b/src/wireviz/wv_colors.py @@ -227,7 +227,7 @@ COLOR_CODES = { "BUVT", "VTBU", "OGVT", "VTOG", "GNVT", "VTGN", "BNVT", "VTBN", "SLVT", "VTSL", ], "TELALT": [ # 25x2: Tip and then ring of each pair - "WHBU", "BU", "WHOG", "OG", "WHGN", "GN", "WHBN", "BN", "WHSL", "SL", + "WHBU", "BU", "WHOG", "OG", "WHGN", "GN", "WHBN", "BN", "WHSL", "SL", "RDBU", "BURD", "RDOG", "OGRD", "RDGN", "GNRD", "RDBN", "BNRD", "RDSL", "SLRD", "BKBU", "BUBK", "BKOG", "OGBK", "BKGN", "GNBK", "BKBN", "BNBK", "BKSL", "SLBK", "YEBU", "BUYE", "YEOG", "OGYE", "YEGN", "GNYE", "YEBN", "BNYE", "YESL", "SLYE", diff --git a/src/wireviz/wv_dataclasses.py b/src/wireviz/wv_dataclasses.py index 415b8d9..ff7fa4b 100644 --- a/src/wireviz/wv_dataclasses.py +++ b/src/wireviz/wv_dataclasses.py @@ -22,8 +22,8 @@ from wireviz.wv_colors import ( ) from wireviz.wv_utils import ( NumberAndUnit, - awg_equiv, aspect_ratio, + awg_equiv, mm2_equiv, parse_number_and_unit, remove_links,